Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort children in tenants view #985

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Sort children in tenants view #985

merged 1 commit into from
Dec 10, 2024

Conversation

alexweininger
Copy link
Member

No description provided.

@alexweininger alexweininger requested a review from a team as a code owner December 10, 2024 18:05
nturinski
nturinski approved these changes Dec 10, 2024
View reviewed changes
Copy link
Member

@nturinski nturinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine, but should we have a sortChildrenImpl that we just have on the providers?

@alexweininger
Copy link
Member Author

This is fine, but should we have a sortChildrenImpl that we just have on the providers?

I think it's easier to just handle it case by case. I realize that it duplicates some code, however it allows us total freedom and keeps the implementation super simple.

@alexweininger alexweininger merged commit e6dafd9 into main Dec 10, 2024
3 checks passed
@alexweininger alexweininger deleted the alex/sapphire-possum branch December 10, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nturinski nturinski nturinski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexweininger @nturinski