serviceconnector: Use createContextValue for tree items #1576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| import * as vscode from 'vscode'; | ||
| import { getIconPath } from "./IconPath"; | ||
| import { ServiceConnectorTreeItem } from "./ServiceConnectorTreeItem"; | ||
|
|
||
| export class ServiceConnectorGroupTreeItem extends AzExtParentTreeItem { | ||
| constructor(parent: AzExtParentTreeItem, public readonly resourceId: string) { | ||
| constructor(parent: AzExtParentTreeItem, public readonly resourceId: string, public readonly contextValuesToAdd: string[]) { |
There was a problem hiding this comment.
Does this need to be public?
There was a problem hiding this comment.
I was following what was done in the appService package but I don't think it technically needs to.
There was a problem hiding this comment.
I'd make it private since it isn't used anywhere else.
alexweininger
approved these changes
Sep 1, 2023
nturinski
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to this issue microsoft/vscode-azureappservice#2565