Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to fix CI for when no packages are changed #1601

Merged
merged 8 commits into from
Oct 2, 2023
Merged

Try to fix CI for when no packages are changed #1601

Changes from 6 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
dccd904
Try to fix CI for when no packages are changed
alexweininger Sep 29, 2023
b9d3cdf
Fixup
alexweininger Sep 29, 2023
4402f1d
Try this
alexweininger Sep 29, 2023
8bfdd0b
Remove comment
alexweininger Sep 29, 2023
47784fa
Fix
alexweininger Sep 29, 2023
fbff8ba
Remove CheckResults job
alexweininger Sep 29, 2023
39779e2
🤠
alexweininger Sep 29, 2023
5e03c1d
Fix
alexweininger Sep 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 1 addition & 10 deletions .github/workflows/packages.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ jobs:
packages: ${{ steps.filter.outputs.changes }}

Build:
if: ${{ fromJson(needs.ChangedPackages.outputs.packages)[0] != null }}
# Use template from https://github.com/microsoft/vscode-azuretools/blob/main/.github/workflows/jobs.yml
uses: ./.github/workflows/jobs.yml
needs: [ChangedPackages]
Expand All @@ -40,13 +41,3 @@ jobs:
strategy:
matrix:
package: ${{ fromJson(needs.ChangedPackages.outputs.packages) }}

CheckResults: # TODO: this will fail if no packages have been modified
# Require all jobs under `build` to have succeeded
# See https://github.com/orgs/community/discussions/26822
if: ${{ always() }}
needs: [Build]
runs-on: ubuntu-latest
steps:
- run: exit 1
if: ${{ contains(needs.*.result, 'failure') || contains(needs.*.result, 'cancelled') }}