auth: Hard-code node-fetch version #1615
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes microsoft/vscode-azurefunctions#3878
There's a lot of weirdness going on here, but the gist of it is whenever fetch is called before
@azure/client-core
, it is overwriting thenode-fetch
package that is used for most of our requests (because we generate our ServiceClients with core-client).For whatever reason, >= v3.7.0 are causing zipdeploy to fail in App Service/Functions, but only on Windows machines. I've investigated a lot and can't pinpoint the exact reason, but my guess is that the socket isn't closing at the same time as it was on earlier versions.
I've spent a lot of time trying to figure this one out, but have thrown in the hat in terms of understanding exactly why/how this is happening. 😐