Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auth: Hard-code node-fetch version #1615

Merged
merged 3 commits into from
Oct 30, 2023
Merged

Conversation

nturinski
Copy link
Member

@nturinski nturinski commented Oct 26, 2023

Fixes microsoft/vscode-azurefunctions#3878

There's a lot of weirdness going on here, but the gist of it is whenever fetch is called before @azure/client-core, it is overwriting the node-fetch package that is used for most of our requests (because we generate our ServiceClients with core-client).

For whatever reason, >= v3.7.0 are causing zipdeploy to fail in App Service/Functions, but only on Windows machines. I've investigated a lot and can't pinpoint the exact reason, but my guess is that the socket isn't closing at the same time as it was on earlier versions.

I've spent a lot of time trying to figure this one out, but have thrown in the hat in terms of understanding exactly why/how this is happening. 😐

@nturinski nturinski requested a review from a team as a code owner October 26, 2023 21:54
@motm32
Copy link
Contributor

motm32 commented Oct 26, 2023

I can confim from my stinkpad that this fixes the issue for me🥳

Copy link
Member

@alexweininger alexweininger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥴

Copy link
Contributor

@bwateratmsft bwateratmsft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How strange...

@nturinski nturinski merged commit 2c73703 into main Oct 30, 2023
4 checks passed
@nturinski nturinski deleted the auth/nat/hardcode-node-fetch branch October 30, 2023 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fail to deploy a project to a function app with an error
4 participants