Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

auth: Refactor getSubscriptions by filtering subs later #1621

Merged
merged 1 commit into from
Nov 7, 2023
Merged

auth: Refactor getSubscriptions by filtering subs later #1621

merged 1 commit into from
Nov 7, 2023

Conversation

alexweininger
Copy link
Member

Filtering the subscriptions at the end to make it possible to know all the discovered subscriptions. Working towards https://github.com/microsoft/azcode-internal/issues/85

@alexweininger alexweininger requested a review from a team as a code owner November 6, 2023 21:58
bwateratmsft
bwateratmsft approved these changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@bwateratmsft bwateratmsft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good but did the old telemetry event send all subs or just the ones matching the filters? If the latter IMO we don't need this.

@alexweininger
Copy link
Member Author

The code looks good but did the old telemetry event send all subs or just the ones matching the filters? If the latter IMO we don't need this.

We are currently sending all discovered subscriptions.

See relevant code

https://github.com/microsoft/vscode-azure-account/blob/1d42902d8bbce0f909c5c17572410b1e970b12c7/src/login/updateSubscriptions.ts#L27

https://github.com/microsoft/vscode-azure-account/blob/1d42902d8bbce0f909c5c17572410b1e970b12c7/src/login/updateSubscriptions.ts#L117-L132

@alexweininger alexweininger merged commit 2ea142c into main Nov 7, 2023
4 checks passed
@alexweininger alexweininger deleted the alex/black-walrus branch November 7, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwateratmsft bwateratmsft bwateratmsft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexweininger @bwateratmsft