Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

appservice: Change deployment polling interval from 5s to 1s #1739

Merged
merged 2 commits into from
Jun 5, 2024
Merged

appservice: Change deployment polling interval from 5s to 1s #1739

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b4462d9
Change deployment polling interval from 5s to 1s
nturinski Jun 5, 2024
4716169
Revert changes to siteClient
nturinski Jun 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion appservice/src/deploy/waitForDeploymentToComplete.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,8 @@ export async function waitForDeploymentToComplete(context: IActionContext & Part
const kuduClient = await site.createClient(context);

const { expectedId, token, locationUrl } = options;
const pollingInterval = options.pollingInterval ?? 5000;
// recommended to poll every second or the deployment id can be recycled before we find it
const pollingInterval = options.pollingInterval ?? 1000;

while (!token?.isCancellationRequested) {
if (locationUrl) {
Expand Down
Loading