-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
auth: Support multi-account scenarios #1827
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwateratmsft
previously approved these changes
Nov 26, 2024
motm32
reviewed
Nov 26, 2024
bwateratmsft
approved these changes
Nov 26, 2024
These are big changes with potential to change behavior, but there are no breaking API typings changes. Should I bump to 4.0.0 or to 3.1.0? |
That's a good question. I'd lean toward 3.1.0 since there aren't strictly breaking changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: bump version appropriately
The changes are basically adding an account parameter wherever there's a tenant parameter. The rest of the changes are fixes for issues that came up with the new multi-account scenarios. The changes in this PR have been tested by two partner teams, Bicep and SCOPE studio.
Fixes:
isSignedIn
method to check for a session across all accounts if no tenant or account is provided.getSubscriptionsForTenant
method to ensure it returns an empty list if the user is not signed in to the specified tenant or account.