azure: Changes to managed identity steps so they are compatible with functions settings conversion #1889
+201
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -506,4 +511,69 @@ export declare const CommonRoleDefinitions: { | |||
| readonly description: "Allows for read, write and delete access to Azure Storage blob containers and data"; | |||
| readonly roleType: "BuiltInRole"; | |||
| }; | |||
| readonly storageBlobDataOwner: { | |||
There was a problem hiding this comment.
where'd you find all this info from? I would put a link in a comment so we know where to get it in the future
azure/index.d.ts
Outdated
|
|
||
| public execute(wizardContext: T, progress: Progress<{ message?: string; increment?: number }>): Promise<void>; | ||
| public shouldExecute(wizardContext: T): boolean; | ||
| } | ||
|
|
||
| export interface Roles { |
There was a problem hiding this comment.
Would Role be more accurate?
alexweininger
previously approved these changes
Feb 26, 2025
|
Nit but do we want to localize the role descriptions? |
nturinski
reviewed
Feb 27, 2025
azure/src/constants.ts
Outdated
| } as RoleDefinition | ||
| } as const; | ||
|
|
||
| export function createRoleId(subscriptionId: string, roleId: string): string { |
There was a problem hiding this comment.
I think an easier to understand way to do this is to change the roleId: string param into role: CommonRoleDefinitions and then in the function itself, access the role id by doing role.name
nturinski
reviewed
Feb 27, 2025
| const resourceType = scopeSplitArr[scopeSplitArr.length - 2] ?? ''; | ||
| const roles = this.roles(); | ||
| if (roles) { | ||
| for (const role of roles) { |
There was a problem hiding this comment.
I don't think we would want to make the whole step fail if one role fails. Maybe do a try/catch so it can continue?
alexweininger
approved these changes
Mar 5, 2025
Comment on lines
+394
to
+398
| export interface Role { | ||
| scopeId: string | undefined; | ||
| roleDefinitionId: string; | ||
| roleDefinitionName: string; | ||
| } |
There was a problem hiding this comment.
Can you add doc strings to this interface?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed to make a couple changes to make the current managed identity steps compatible with converting settings.
Things I have changed:
ResourceGroupListStepto theUserAssignedIdentityListStep. Users who are converting will not have specified a resource group prior to choosing to create a managed identityRoleAssignmentExecuteStepto assign multiple roles in the step. It is common not only for converting to assign more than one roleTODO: