Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure Account -> Azure Resources and GitLab support removal, GitHub addition #6867

Merged
merged 4 commits into from
Dec 1, 2023

Conversation

bwateratmsft
Copy link
Contributor

@bwateratmsft bwateratmsft commented Nov 30, 2023

A couple of things in this PR.

  • Azure Account is being slowly deprecated and replaced with the built-in Microsoft authentication provider. I could use some help with the verbiage here. The Azure Resources extension is required to sign in to some tenants (e.g., those with extra MFA after the primary sign-in) and is recommended (though not strictly required) if a sovereign cloud is being used.
  • GitLab container registry support has been removed from the Docker extension (see Can't login to GitLab vscode-docker#4132)
  • GitHub container registry support has been added to the Docker extension (see Support third-party registries vscode-docker#869)

Closes microsoft/vscode-docker#4147

@bwateratmsft
Copy link
Contributor Author

/cc @fiveisprime, @alexweininger

Alex, we may want to add some specific documentation somewhere on the docs site about the Azure Resources extension, with particular focus on sign in (sovereign clouds, MFA-requiring tenants, etc.)

@fiveisprime
Copy link
Member

The changes look good. The Python and Java articles are pretty intense - it's not something to change in this PR, but I wonder how helpful those are.

Alex, we may want to add some specific documentation somewhere on the docs site about the Azure Resources extension, with particular focus on sign in (sovereign clouds, MFA-requiring tenants, etc.)

I like how the Docker section has an overview. Maybe the Azure section could use an overview rather than the "extensions" page that goes over the Azure Resources extension. That "extensions" landing page was built when it was more difficult to discover the various service extensions, which isn't so much an issue now that every service shows up by default.

@gregvanl gregvanl requested a review from ghogen December 1, 2023 18:26
@ghogen
Copy link
Collaborator

ghogen commented Dec 1, 2023

@bwateratmsft
Thanks, this looks great, I just have one question about that first image that shows your GitHub id. I don't know the VS Code policies as well, but on the Learn platform, we have a PII policy that would ask us to adjust the image in some way to not show any identifiable information.

@bwateratmsft
Copy link
Contributor Author

@bwateratmsft Thanks, this looks great, I just have one question about that first image that shows your GitHub id. I don't know the VS Code policies as well, but on the Learn platform, we have a PII policy that would ask us to adjust the image in some way to not show any identifiable information.

I'll take a new screenshot without. But the old GitLab image had a GitLab username in it so I didn't think it'd matter.

@bwateratmsft
Copy link
Contributor Author

@ghogen these can be merged at any time, all the changes are already live in the Docker extension.

@gregvanl gregvanl merged commit 515ec5e into microsoft:main Dec 1, 2023
1 of 2 checks passed
@gregvanl
Copy link

gregvanl commented Dec 1, 2023

published

@bwateratmsft bwateratmsft deleted the bmw/azureAccount branch December 4, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants