-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Azure Account -> Azure Resources and GitLab support removal, GitHub addition #6867
Conversation
/cc @fiveisprime, @alexweininger Alex, we may want to add some specific documentation somewhere on the docs site about the Azure Resources extension, with particular focus on sign in (sovereign clouds, MFA-requiring tenants, etc.) |
The changes look good. The Python and Java articles are pretty intense - it's not something to change in this PR, but I wonder how helpful those are.
I like how the Docker section has an overview. Maybe the Azure section could use an overview rather than the "extensions" page that goes over the Azure Resources extension. That "extensions" landing page was built when it was more difficult to discover the various service extensions, which isn't so much an issue now that every service shows up by default. |
@bwateratmsft |
I'll take a new screenshot without. But the old GitLab image had a GitLab username in it so I didn't think it'd matter. |
@ghogen these can be merged at any time, all the changes are already live in the Docker extension. |
published |
A couple of things in this PR.
Closes microsoft/vscode-docker#4147