-
Notifications
You must be signed in to change notification settings - Fork 464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add filter state management #18602
Merged
Merged
Add filter state management #18602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cssuh
requested review from
kburtram,
aasimkhan30,
caohai,
laurennat,
lewis-sanchez and
Benjin
as code owners
January 28, 2025 00:30
PR Changes
|
Benjin
reviewed
Jan 28, 2025
src/reactviews/pages/QueryResult/table/plugins/headerFilter.plugin.ts
Outdated
Show resolved
Hide resolved
src/reactviews/pages/QueryResult/table/plugins/headerFilter.plugin.ts
Outdated
Show resolved
Hide resolved
src/reactviews/pages/QueryResult/table/plugins/headerFilter.plugin.ts
Outdated
Show resolved
Hide resolved
src/reactviews/pages/QueryResult/table/plugins/headerFilter.plugin.ts
Outdated
Show resolved
Hide resolved
Benjin
reviewed
Jan 28, 2025
Benjin
reviewed
Feb 3, 2025
src/reactviews/pages/QueryResult/table/plugins/headerFilter.plugin.ts
Outdated
Show resolved
Hide resolved
src/reactviews/pages/QueryResult/table/plugins/headerFilter.plugin.ts
Outdated
Show resolved
Hide resolved
src/reactviews/pages/QueryResult/table/plugins/headerFilter.plugin.ts
Outdated
Show resolved
Hide resolved
…e when switching out of react view
Benjin
reviewed
Feb 5, 2025
src/reactviews/pages/QueryResult/table/plugins/headerFilter.plugin.ts
Outdated
Show resolved
Hide resolved
src/reactviews/pages/QueryResult/table/plugins/headerFilter.plugin.ts
Outdated
Show resolved
Hide resolved
Benjin
approved these changes
Feb 5, 2025
lewis-sanchez
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds filter state management
Before:
filters were only tracked on a column.id level, which led to issues like #18514.
After:
Filters are tracked at a (query editor) uri level, containing multiple sets of filters for each grid id and column id respectively.
I also added a singleton store, which allows us to store state outside of the react state (this is needed in cases where we don't want to trigger a re-render which happens every time the react state is updated). We don't need to re-render here because that is triggered and managed by the slickgrid library.
Fixes #18514