Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fnmatch instead of pathlibs match #220

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

Mutantpenguin
Copy link
Contributor

pathlibs match doesn't work with fnmatch patterns, but these are necessary to exclude whole subfolders for example

fixes #213

pathlibs match doesn't work with fnmatch patterns, but these are necessary to exclude whole subfolders for example
@karthiknadig karthiknadig self-requested a review November 13, 2023 18:12
@karthiknadig karthiknadig self-assigned this Nov 13, 2023
@karthiknadig karthiknadig added the bug Issue identified by VS Code Team member as probable bug label Nov 13, 2023
@karthiknadig karthiknadig enabled auto-merge (squash) November 13, 2023 18:48
@karthiknadig karthiknadig merged commit 0619b3b into microsoft:main Nov 13, 2023
karthiknadig pushed a commit to karthiknadig/vscode-mypy that referenced this pull request Nov 13, 2023
pathlibs match doesn't work with fnmatch patterns, but these are necessary to exclude whole subfolders for example
karthiknadig pushed a commit that referenced this pull request Nov 13, 2023
pathlibs match doesn't work with fnmatch patterns, but these are necessary to exclude whole subfolders for example
@Mutantpenguin Mutantpenguin deleted the patch-1 branch November 14, 2023 07:14
@Mutantpenguin
Copy link
Contributor Author

@karthiknadig Is there (pretty please) any chance for a new release with this change? It's almost 10 month since the last release of this extension.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mypy-type-checker.ignorePatterns doesn't work with glob pattern as documented
3 participants