-
Notifications
You must be signed in to change notification settings - Fork 29.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add options for user provided extension gallery #129764
Conversation
Option 1: product.json in userdata, will be merged with general product.json and may override different entries Option 2: Adjust gallery URLs via environment variables
... Note to the hygiene check: the document is formatted by vscode via "Format Document" already. |
I am sorry that we do not accept PR for this feature request because it needs lot of brain storming, design discussions and also product team approvals. |
There is a feature request since begin of 2017, since back then MS provided answers along
It has nearly 1000 votes so obviously is something the users are interested in.
@sandy081 Do you really want to tell me that there was no brain storming and design discussion about that @microsoft in the last 4 and a half year? I note that there are two options provided in the PR:
I suggest the following: go to the team, check your previous decisions and design goals on this (if there are some); then check the two options provided in the PR and discuss if any of those would harm the general design; if not tell me if there are necessary adjustments and then we'll finally be able to solve this issue. What do you say? BTW: I (and at least 1000 other users) would totally be happy if you take a design decision to just move those entries from an entry in product.json to a user setting with the current default - but as this is a completely change of the current way other than this PR which provides a possible override I did not do that. |
I understand your concerns and to give more info, this is in our and Marketplace team's road map and we are discussing about a solution here with Marketplace team and the details are not yet concrete. Hence I would not like to have a temporary or workaround solution here. Hope you understand. cc @prashantvc |
Option 1: product.json in userdata, will be merged with general product.json and may override different entries
Option 2: Adjust gallery URLs via environment variables
This PR fixes #21839