Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add options for user provided extension gallery #129764

Closed
wants to merge 1 commit into from

Conversation

GitMensch
Copy link
Contributor

Option 1: product.json in userdata, will be merged with general product.json and may override different entries
Option 2: Adjust gallery URLs via environment variables

This PR fixes #21839

Option 1: product.json in userdata, will be merged with general product.json and may override different entries
Option 2: Adjust gallery URLs via environment variables
@ghost
Copy link

ghost commented Jul 29, 2021

CLA assistant check
All CLA requirements met.

@GitMensch GitMensch marked this pull request as draft July 29, 2021 09:31
@GitMensch GitMensch marked this pull request as ready for review July 29, 2021 09:33
@GitMensch
Copy link
Contributor Author

... Note to the hygiene check: the document is formatted by vscode via "Format Document" already.

@sandy081
Copy link
Member

I am sorry that we do not accept PR for this feature request because it needs lot of brain storming, design discussions and also product team approvals.

@sandy081 sandy081 closed this Jul 29, 2021
@GitMensch
Copy link
Contributor Author

There is a feature request since begin of 2017, since back then MS provided answers along

Currently we don't have a way to do this but it's not the first time we have heard this request [...]. We don't have this in our current backlog but this will help us keep track of it.

It has nearly 1000 votes so obviously is something the users are interested in.
Among those we've seen a lot of corporate users that currently need to manually install vsix, often after getting approval form their IT staff - a self-hosted extension marketplace within the local net would solve this and if I remember correctly there are at least 2 free and open source marketplaces - nothing that MS even needs to take care.

I am sorry that we do not accept PR for this feature request because it needs lot of brain storming, design discussions and also product team approvals.

@sandy081 Do you really want to tell me that there was no brain storming and design discussion about that @microsoft in the last 4 and a half year?

I note that there are two options provided in the PR:

  • the first one allows a one time setup in the user data directory
  • the second one allows a setting via environment, so can possibly override both the current default and the possibly changed one by the first option (if it is used) and other than the one-time-override is also perfectly working with logon scripts
  • neither of those change ANY default that MS provides (only if the user manually provided one of these)

I suggest the following: go to the team, check your previous decisions and design goals on this (if there are some); then check the two options provided in the PR and discuss if any of those would harm the general design; if not tell me if there are necessary adjustments and then we'll finally be able to solve this issue.

What do you say?

BTW: I (and at least 1000 other users) would totally be happy if you take a design decision to just move those entries from an entry in product.json to a user setting with the current default - but as this is a completely change of the current way other than this PR which provides a possible override I did not do that.

@sandy081
Copy link
Member

I understand your concerns and to give more info, this is in our and Marketplace team's road map and we are discussing about a solution here with Marketplace team and the details are not yet concrete. Hence I would not like to have a temporary or workaround solution here. Hope you understand.

cc @prashantvc

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Support for private marketplace/gallery
2 participants