add tests for terminal suggest widget, fix some bugs #234445
Open
+112
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
meganrogge
commented
Nov 22, 2024
•
meganrogge
commented
|
Actually wip realized something |
Tyriar
requested changes
Nov 22, 2024
| }); | ||
| }); | ||
|
|
||
| function createTestCase(name: string, commandLineWithCursor: string, expectedSpecs: string[], resourcesRequested: 'files' | 'folders' | 'both' | 'neither', availableSpecs: Fig.Spec[], availableCommands: Set<string>): void { |
There was a problem hiding this comment.
If you move this inside suite you'll be able to access variables you declare in that block. This lets you do things like this:
let commands: string[]
setup(() => {
commands = ['default', 'set', ...];
});
function assertCompletions() {
// references commands
}
test(() => {
commands = ['custom test commands'];
});
| }); | ||
|
|
||
| suite('prefix: c', () => { | ||
| createTestCase(`No available commands:`, 'c|', [], 'neither', availableSpecs, new Set()); |
There was a problem hiding this comment.
I'd only generate tests inside a function like this if they originate from some array of specifications which is sometimes useful. Pulling the test call out will make integration with IDEs better and make them easier to understand.
There was a problem hiding this comment.
there will be quite a bit of duplication if I do this
There was a problem hiding this comment.
also not sure what you mean about integration with other IDEs
meganrogge
commented
Nov 23, 2024
meganrogge
changed the title
meganrogge
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.