fixes https://github.com/microsoft/vscode-copilot-release/issues/3520 #239359
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where updates to the dropdown did not honor the initial options passed in. It also uses
menuAsChild: falsefor the the dropdown menu in the chat widget. This is a tradeoff situation. The context menu rendered as a child of the dropdown button preserves focus state properly. However this often has z-index issues. Setting it to false allows it to render above the rest of the workbench but focus will be sent to an element outside of the chat widget temporarily. This doesn't seem to cause any issues but it is something to be aware of.