Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Microsoft.Windows.Setting.Privacy #131

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

Gijsreyn
Copy link
Contributor

@Gijsreyn Gijsreyn commented Nov 14, 2024


Addres issue #102

Microsoft Reviewers: Open in CodeFlow

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@Gijsreyn Gijsreyn marked this pull request as ready for review November 15, 2024 03:10
@Gijsreyn
Copy link
Contributor Author

Gijsreyn commented Nov 15, 2024

@denelon I wanted to put this one on review to keep the pull request rather small to get the ball rolling. The design is a little different compared the other modules, so that's also another reason.

I know I'm throwing in some PRs here and there and that you have a lot on your plate, so I really appreciate it already that you took the time to look at this. If there is a moment, would you mind checking out the pull request or your favorite colleague?

Thanks,
Gijs

P.S. There was a tiny bug in the New-DscResourceModule.ps1 script. I included it in here

This comment has been minimized.

@denelon
Copy link
Contributor

denelon commented Nov 15, 2024

@Gijsreyn I really appreciate all the activity here! It's exciting being a bit of a pioneer 😊. Since this is touching privacy settings, we need to have an internal review. I'll see if we can get that done as quickly as possible.

Copy link

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

❌ Errors Count
ℹ️ candidate-pattern 1
❌ ignored-expect-variant 2

See ❌ Event descriptions for more information.

These words are not needed and should be removed VGpu wildcards worktree

Pattern suggestions ✂️ (1)

You could add these patterns to .github/actions/spelling/patterns.txt:

# Automatically suggested patterns

# hit-count: 1 file-count: 1
# GitHub SHAs (markdown)
(?:\[`?[0-9a-f]+`?\]\(https:/|)/(?:www\.|)github\.com(?:/[^/\s"]+){2,}(?:/[^/\s")]+)(?:[0-9a-f]+(?:[-0-9a-zA-Z/#.]*|)\b|)

If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

@Gijsreyn
Copy link
Contributor Author

Thanks for the shift response Demitrius and that excitment is mutual. I like the content here and contribute 😊. I'll keep this one on hold for now, as I'm curious to both feedbacks with the new approach I took.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants