-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Microsoft.Windows.Setting.Privacy #131
base: main
Are you sure you want to change the base?
Conversation
bcd98e3
to
9cd2f95
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@denelon I wanted to put this one on review to keep the pull request rather small to get the ball rolling. The design is a little different compared the other modules, so that's also another reason. I know I'm throwing in some PRs here and there and that you have a lot on your plate, so I really appreciate it already that you took the time to look at this. If there is a moment, would you mind checking out the pull request or your favorite colleague? Thanks, P.S. There was a tiny bug in the |
This comment has been minimized.
This comment has been minimized.
@Gijsreyn I really appreciate all the activity here! It's exciting being a bit of a pioneer 😊. Since this is touching privacy settings, we need to have an internal review. I'll see if we can get that done as quickly as possible. |
@check-spelling-bot Report🔴 Please reviewSee the 📂 files view, the 📜action log, or 📝 job summary for details.
See ❌ Event descriptions for more information. These words are not needed and should be removedVGpu wildcards worktreePattern suggestions ✂️ (1)You could add these patterns to
If the flagged items are 🤯 false positivesIf items relate to a ...
|
Thanks for the shift response Demitrius and that excitment is mutual. I like the content here and contribute 😊. I'll keep this one on hold for now, as I'm curious to both feedbacks with the new approach I took. |
Addres issue #102
Microsoft Reviewers: Open in CodeFlow