Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add whatif and export support NpmDsc #132

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

Gijsreyn
Copy link
Contributor

@Gijsreyn Gijsreyn commented Nov 16, 2024


Addresses export and whatif support for NpmDsc.

Microsoft Reviewers: Open in CodeFlow

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@Gijsreyn
Copy link
Contributor Author

Hey @ryfu-msft. I liked to work on NPM and wanted to expand a bit on it. I've made some updates that I believe will enhance its functionality. Could you please review my pull request and share your feedback? Thanks!

@Gijsreyn Gijsreyn changed the title Add whatif and export support Add whatif and export support NpmDsc Nov 17, 2024
@ryfu-msft
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Gijsreyn
Copy link
Contributor Author

Thanks for the run Ryan, can you please run it once again? I added some debug line to see if there is actual result. It's pretty strange, because when I ran it locally, it succeeded.

image

@ryfu-msft
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Gijsreyn
Copy link
Contributor Author

I couldn't really make sense why it was not working, until I started running it under my own Azure Pipelines agents. After tremendous debugging, I rewrote the logic to determine the paths to look for. To reduce the calling to npm, I have included one hardcoded path. If that is not found, it will attempt to use the npm cache list to find it. Now I can see the following:

image

Can you give it another go @ryfu-msft ? Thanks in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants