Skip to content
This repository has been archived by the owner on Feb 20, 2021. It is now read-only.

Fixes client buffer size underflow #546

Open
wants to merge 2 commits into
base: 3.2
Choose a base branch
from

Conversation

lgsonic
Copy link

@lgsonic lgsonic commented Apr 30, 2017

Fixes client buffer size underflow due to miscalculation of object memory size.

Client buffer size increases by the value of getStringObjectSdsUsedMemory(o), while decreases by the value of sdsZmallocSize(o->ptr). The mismatch might cause client buffer size underflow and consequent connection close as the limit of client buffer size is exceeded.

Refer to https://github.com/antirez/redis/blob/3.2/src/networking.c

@jdawgtech
Copy link

Hi, I am also constantly seeing this issue in our setup whenever client starts writing a lot of data in a short time.

the omem value reported is suspect (very large number)

can we have a release with a fix to this issue please?

using version 3.0.503
a Redis master located in Chicago Data centre (VM Windows 2012 R2), has two slaves (one in London DC, and other in Hong Kong DC)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants