This repository has been archived by the owner on Feb 20, 2021. It is now read-only.
AUTH immediately after creating a connection #559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While using redis-benchmark with more that one client for eg. -c 500, it would first create 500 connections and then authenticate them by sending AUTH command over the wire.
This creates an issue while trying to benchmark Redis endpoints (like Azure Redis) that implements DDOS attack prevention by dropping connections in an event of high number of unauthenticated clients.
With this pull request I am proposing to send AUTH command immediately after a connection has been created by redis-benchmark to improve this scenario.