Set binary type to string #799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikithauc
requested review from
baywet,
ddyett,
MIchaelMainer,
zengin,
ramsessanchez,
Ndiritu,
andrueastman,
SilasKenneth and
rkodev
as code owners
zengin
suggested changes
Aug 9, 2022
| typeStr = "number"; | ||
| break; | ||
| case "Binary": // let binary: number = 0b1010; |
There was a problem hiding this comment.
Could you please update the comments as well to reflect the change?
baywet
approved these changes
Aug 9, 2022
zengin
approved these changes
Aug 9, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes for microsoftgraph/msgraph-typescript-typings#322
and microsoftgraph/msgraph-typescript-typings#310
Microsoft Reviewers: Open in CodeFlow