Add support for Python 3.13 #804
Conversation
Fixes microsoftgraph#704 Add support for Python 3.13 and update dependencies. * **pyproject.toml** - Add Python 3.13 to the `requires-python` field. - Add Python 3.13 to the `classifiers` field. - Set higher requirement for all `microsoft-kiota-....` packages to at least 1.8.0. * **.github/workflows/build.yml** - Add Python 3.13 to the `matrix` for testing. * **requirements-dev.txt** - Update dependencies to be compatible with Python 3.13. * **tests/conftest.py** - Add a test to check for Python 3.13 compatibility. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/microsoftgraph/msgraph-sdk-python-core/issues/704?shareId=XXXX-XXXX-XXXX-XXXX).
… requirements * Add Python 3.13 to the `requires-python` field * Add Python 3.13 to the `classifiers` field * Set higher requirement for all `microsoft-kiota-....` packages to at least 1.8.0
| from dataclasses import dataclass | ||
| from typing import Optional, TypeVar |
There was a problem hiding this comment.
Global: I believe the import changes should be reverted. According to https://docs.python.org/3/library/typing.html#typing.Callable, the alias typing.Callable is deprecated and should use the import from collections.abc
There was a problem hiding this comment.
That might be so, but the test framework does not import it from collections.abc so the tests would fail on 3.13 (which is why I also tried updating pytest, but that didn't work out).
Apart from that, all other things are imported from typings, in my opinion this looks better.
There was a problem hiding this comment.
let's fix the test project configuration then. This is a change we've made on the kiota dependencies, and we'll want to be consistent across the repositories.
There was a problem hiding this comment.
Out of curiosity, @svrooij could you share the errors you mentioned seeing for everyone's benefit?
As @baywet, the kiota dependencies do have this change too and don't seem to fail. As, these are aliases that will probably be removed in the future so it would be better to be set for this if we can.
|
Fixes #704
Add support for Python 3.13 and update dependencies.
pyproject.toml
requires-pythonfield.classifiersfield.microsoft-kiota-....packages to at least 1.8.0..github/workflows/build.yml
matrixfor testing.requirements-dev.txt
tests/conftest.py
For more details, open the Copilot Workspace session.