chore: add library_test.py #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15 +/- ##
=====================================
Coverage 0.09% 0.09%
=====================================
Files 77 77
Lines 6561 6561
=====================================
Hits 6 6
Misses 6555 6555 ☔ View full report in Codecov by Sentry. |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
rokam
suggested changes
May 24, 2024
|
Thank you for this library! It gave me a great idea how to test the library properly. We could record the http network traffic using this test (and similar ones for other devices) and using the recorded network traffic i can build a mock service that can be used to run these tests against. What do you think? |
Totally agree |
rokam
approved these changes
May 24, 2024
chemelli74
added a commit
to chemelli74/midea-local
that referenced
this pull request
May 25, 2024
* chore: add library_test.py * Apply suggestions from code review --------- Co-authored-by: Lucas Mindêllo de Andrade <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.