Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for MeijuCloud #17

Merged
merged 3 commits into from
May 26, 2024
Merged

Add tests for MeijuCloud #17

merged 3 commits into from
May 26, 2024

Conversation

rokam
Copy link
Contributor

@rokam rokam commented May 24, 2024

Adds coverage for login and get_keys methods

@codecov-commenter
Copy link

codecov-commenter commented May 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 3.41%. Comparing base (158eb51) to head (4f69ee4).

Additional details and impacted files
@@           Coverage Diff            @@
##            main     #17      +/-   ##
========================================
+ Coverage   0.09%   3.41%   +3.32%     
========================================
  Files         77      77              
  Lines       6561    6561              
========================================
+ Hits           6     224     +218     
+ Misses      6555    6337     -218     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

chemelli74
chemelli74 previously approved these changes May 25, 2024
Copy link
Member

@chemelli74 chemelli74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@rokam rokam requested a review from chemelli74 May 25, 2024 16:33
@rokam rokam changed the title Add tests for MeijuCloud Draft: Add tests for MeijuCloud May 25, 2024
@rokam rokam changed the title Draft: Add tests for MeijuCloud Add tests for MeijuCloud May 25, 2024
Copy link
Member

@chemelli74 chemelli74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not very good in writing tests, but seems good

@rokam rokam merged commit 242b032 into main May 26, 2024
3 checks passed
@rokam rokam deleted the test/meijucloud-login branch May 26, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants