Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cleanup and complete body and subbody types lists #325

Merged
merged 7 commits into from
Oct 15, 2024

Conversation

chemelli74
Copy link
Member

@chemelli74 chemelli74 requested review from rokam and wuwentao October 13, 2024 12:33
@codecov-commenter
Copy link

codecov-commenter commented Oct 13, 2024

Codecov Report

Attention: Patch coverage is 88.54167% with 33 lines in your changes missing coverage. Please review.

Project coverage is 41.33%. Comparing base (c51b50d) to head (588de4b).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
midealocal/devices/b6/message.py 0.00% 6 Missing ⚠️
midealocal/devices/x13/message.py 0.00% 6 Missing ⚠️
midealocal/message.py 98.29% 4 Missing ⚠️
midealocal/devices/c2/message.py 0.00% 3 Missing ⚠️
midealocal/devices/b0/message.py 0.00% 2 Missing ⚠️
midealocal/devices/e2/message.py 0.00% 2 Missing ⚠️
midealocal/devices/e3/message.py 0.00% 2 Missing ⚠️
midealocal/devices/fa/message.py 0.00% 2 Missing ⚠️
midealocal/devices/fc/message.py 0.00% 2 Missing ⚠️
midealocal/devices/fd/message.py 0.00% 2 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #325      +/-   ##
==========================================
+ Coverage   39.91%   41.33%   +1.42%     
==========================================
  Files          84       84              
  Lines        7611     7806     +195     
==========================================
+ Hits         3038     3227     +189     
- Misses       4573     4579       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chemelli74
Copy link
Member Author

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

@rokam when you have a couple of spare minutes, please install the app

Copy link
Contributor

@rokam rokam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sound great. Just don't remove the current enums. Let's deprecated first to avoid breaking change.

wuwentao
wuwentao previously approved these changes Oct 14, 2024
rokam
rokam previously requested changes Oct 14, 2024
midealocal/message.py Show resolved Hide resolved
midealocal/message.py Show resolved Hide resolved
chemelli74 and others added 3 commits October 15, 2024 10:12
Co-authored-by: Lucas Mindêllo de Andrade <[email protected]>
Co-authored-by: Lucas Mindêllo de Andrade <[email protected]>
@chemelli74 chemelli74 force-pushed the chemelli74-complete-list branch from e146ae8 to 1479689 Compare October 15, 2024 10:12
Copy link
Contributor

@rokam rokam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chemelli74 chemelli74 merged commit 914dcb8 into midea-lan:main Oct 15, 2024
10 checks passed
@chemelli74 chemelli74 deleted the chemelli74-complete-list branch October 15, 2024 10:21
@rokam rokam mentioned this pull request Oct 15, 2024
chemelli74 pushed a commit that referenced this pull request Oct 15, 2024
🤖 I have created a release *beep* *boop*
---


## [6.0.3](v6.0.2...v6.0.3)
(2024-10-15)


### Bug Fixes

* cleanup and complete body and subbody types lists
([#325](#325))
([914dcb8](914dcb8))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants