feat(ed): add new query01 msg for ed device #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wuwentao
force-pushed
the
add_ed_query
branch
from
2b88e7a to
725fb6b
Compare
rokam
previously requested changes
Oct 16, 2024
|
@rokam please check the source code from device.py with refresh_status steps. |
rokam
suggested changes
Oct 17, 2024
| return [MessageQuery(self._message_protocol_version, self._device_class)] | ||
| return [ | ||
| MessageQuery(self._message_protocol_version), | ||
| MessageQuery01(self._message_protocol_version), |
There was a problem hiding this comment.
Suggested change
| MessageQuery01(self._message_protocol_version), | |
| MessageQuery(self._message_protocol_version, ListTypes.X01), |
| """Midea ED device build query.""" | ||
| return [MessageQuery(self._message_protocol_version, self._device_class)] | ||
| return [ | ||
| MessageQuery(self._message_protocol_version), |
There was a problem hiding this comment.
Suggested change
| MessageQuery(self._message_protocol_version), | |
| MessageQuery(self._message_protocol_version, ListTypes.X00), |
| assert isinstance(queries[0], MessageQuery) | ||
| assert isinstance(queries[1], MessageQuery01) |
| @@ -14,6 +14,7 @@ | |||
| MessageEDResponse, | |||
| MessageNewSet, | |||
| MessageQuery, | |||
| MessageQuery01, | |||
There was a problem hiding this comment.
Suggested change
| MessageQuery01, |
| @@ -77,6 +81,26 @@ def _body(self) -> bytearray: | |||
| return bytearray([0x01]) | |||
|
|
|||
|
|
|||
| class MessageQuery01(MessageEDBase): | |||
rokam
suggested changes
Oct 17, 2024
| @@ -77,9 +83,12 @@ def _use_new_set(self) -> bool: | |||
| # if (self.sub_type > 342 or self.sub_type == 340) else False | |||
| return True | |||
|
|
|||
| def build_query(self) -> list[MessageQuery]: | |||
| def build_query(self) -> list[MessageQuery | MessageQuery01]: | |||
There was a problem hiding this comment.
Suggested change
| def build_query(self) -> list[MessageQuery | MessageQuery01]: | |
| def build_query(self) -> list[MessageQuery]: |
There was a problem hiding this comment.
if device NOT support MessageQuery and ONLY support MessageQuery01, we only use MessageQuery with the same name, when device send MessageQuery with body 00, it will add MessageQuery to self._unsupported_protocol, so MessageQuery with body 01 will be ignored and can't work anymore.
this is the reason why we need to add it with a different class name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add new query01 msg for ed devices
fix wuwentao/midea_ac_lan#352