feat(db): add new attributes for db device #329
Conversation
| 0x01: "Low", | ||
| 0x02: "Mid", | ||
| 0x03: "High", | ||
| 0x04: "4", |
There was a problem hiding this comment.
Should be "translated" to a string: VeryHigh ?
There was a problem hiding this comment.
this is the origina value from lua script.
midealocal/devices/db/__init__.py
Outdated
| if value in MideaDBDevice._status: | ||
| self._attributes[DeviceAttributes.status] = ( | ||
| MideaDBDevice._status.get(value) | ||
| ) | ||
| else: | ||
| self._attributes[DeviceAttributes.status] = None |
There was a problem hiding this comment.
| if value in MideaDBDevice._status: | |
| self._attributes[DeviceAttributes.status] = ( | |
| MideaDBDevice._status.get(value) | |
| ) | |
| else: | |
| self._attributes[DeviceAttributes.status] = None | |
| self._attributes[DeviceAttributes.status] = ( | |
| MideaDBDevice._status.get(value) | |
| ) |
The purpose of get() is exactly to avoid the if
There was a problem hiding this comment.
value may not list in _status, just return None.
There was a problem hiding this comment.
it's a very simple logic, if value not in list, we can't return error, just set the status to None.
so why you thinks the value always in _status ? we just list what we want to display, and it's not a full list with different sub modle for this device.
if there is any issue ,please add your comments, thanks
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
|
add new attributes for db device
fix wuwentao/midea_ac_lan#335
the remaining PR will be finished in midea_ac_lan with another PR later.