Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dc): add new attributes for exist dc device #330

Merged
merged 7 commits into from
Jan 15, 2025
Merged

Conversation

wuwentao
Copy link
Member

add new attributes for dc device
dc device should share most of the same feature as db device, add it at the same time

the remaining PR will be finished in midea_ac_lan with another PR later.

@github-actions github-actions bot added the enhancement New feature or request label Oct 16, 2024
@wuwentao wuwentao marked this pull request as draft October 16, 2024 09:11
Copy link
Contributor

@rokam rokam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, can you please add unit testing?

@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 31 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
midealocal/devices/dc/__init__.py 0.00% 21 Missing ⚠️
midealocal/devices/dc/message.py 0.00% 10 Missing ⚠️
Files with missing lines Coverage Δ
midealocal/devices/dc/message.py 0.00% <0.00%> (ø)
midealocal/devices/dc/__init__.py 0.00% <0.00%> (ø)

@wuwentao wuwentao marked this pull request as ready for review January 15, 2025 07:03
@wuwentao wuwentao dismissed chemelli74’s stale review January 15, 2025 07:15

thank you for your review, already commit with the review comments

@wuwentao wuwentao merged commit 10c15b6 into main Jan 15, 2025
7 checks passed
@wuwentao wuwentao deleted the add_dc_feature branch January 15, 2025 08:01
@wuwentao wuwentao added this to the v6.0.4 milestone Jan 15, 2025
wuwentao added a commit that referenced this pull request Jan 15, 2025
🤖 I have created a release *beep* *boop*
---


##
[6.1.0](v6.0.3...v6.1.0)
(2025-01-15)


### Features

* **c3:** add disinfect and fix tbh set error
([#340](#340))
([5f5224b](5f5224b))
* **cd:** add water_level and temperature option with customize
lua_protocol
([#345](#345))
([db2fdf0](db2fdf0))
* **cloud:** add plugin download for meiju and smarthome
([#336](#336))
([30de473](30de473))
* **db:** add new attributes for db device
([#329](#329))
([da38007](da38007))
* **dc:** add new attributes for exist dc device
([#330](#330))
([10c15b6](10c15b6))
* **e1:** add new attributes for e1 device
([#337](#337))
([9afa160](9afa160))
* **ed:** add all query msg for 0xED device
([#328](#328))
([30ba082](30ba082))


### Bug Fixes

* fix:
([db2fdf0](db2fdf0))
* **device:** no supported protocol caused high cpu usage
([#346](#346))
([013aee4](013aee4))


### Documentation

* add collected lua scripts
([#331](#331))
([e1a3855](e1a3855))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants