Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(c3): add disinfect and fix tbh set error #340

Merged
merged 9 commits into from
Jan 15, 2025
Merged

Conversation

wuwentao
Copy link
Member

@wuwentao wuwentao commented Dec 13, 2024

  1. current disinfect is the same as tbh, fix tbh set error
  2. add disinfect query
  3. TO BE DONE: set disinfect, as it's a switch
  4. add some addition attrs

fix wuwentao/midea_ac_lan#399

and wuwentao/midea_ac_lan#404 maybe need a new PR for it.

@github-actions github-actions bot added the enhancement New feature or request label Dec 13, 2024
@wuwentao wuwentao marked this pull request as draft December 13, 2024 10:10
@wuwentao wuwentao marked this pull request as ready for review January 15, 2025 07:16
@wuwentao
Copy link
Member Author

most of the code logic is ready, and test with some C3 devices, new query is not support, will merge it and check for more C3 device debug log, try to improve it in future release.

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 43.96552% with 65 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
midealocal/devices/c3/message.py 43.75% 63 Missing ⚠️
midealocal/devices/c3/__init__.py 50.00% 2 Missing ⚠️
Files with missing lines Coverage Δ
midealocal/devices/c3/__init__.py 98.50% <50.00%> (-1.50%) ⬇️
midealocal/devices/c3/message.py 71.74% <43.75%> (-28.26%) ⬇️

@wuwentao wuwentao merged commit 5f5224b into main Jan 15, 2025
7 checks passed
@wuwentao wuwentao deleted the c3_add_disinfect branch January 15, 2025 09:58
wuwentao added a commit that referenced this pull request Jan 15, 2025
🤖 I have created a release *beep* *boop*
---


##
[6.1.0](v6.0.3...v6.1.0)
(2025-01-15)


### Features

* **c3:** add disinfect and fix tbh set error
([#340](#340))
([5f5224b](5f5224b))
* **cd:** add water_level and temperature option with customize
lua_protocol
([#345](#345))
([db2fdf0](db2fdf0))
* **cloud:** add plugin download for meiju and smarthome
([#336](#336))
([30de473](30de473))
* **db:** add new attributes for db device
([#329](#329))
([da38007](da38007))
* **dc:** add new attributes for exist dc device
([#330](#330))
([10c15b6](10c15b6))
* **e1:** add new attributes for e1 device
([#337](#337))
([9afa160](9afa160))
* **ed:** add all query msg for 0xED device
([#328](#328))
([30ba082](30ba082))


### Bug Fixes

* fix:
([db2fdf0](db2fdf0))
* **device:** no supported protocol caused high cpu usage
([#346](#346))
([013aee4](013aee4))


### Documentation

* add collected lua scripts
([#331](#331))
([e1a3855](e1a3855))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
1 participant