IoT connections #2
Conversation
…, also worked on layout of mdns scan page
…nnections as well
…upport, fixed mdns bug
…ether darkmode is on and returns true if so
…ded fallback images for company logos if internet is down
lib/connection.dart
Outdated
| /* | ||
| * This file is part of the Embla Flutter app | ||
| * Copyright (c) 2020-2022 Miðeind ehf. <[email protected]> | ||
| * Original author: Sveinbjorn Thordarson |
There was a problem hiding this comment.
Header copy paste. Ekki setja nafnið mitt á kóðann ykkar :). Settu bara nöfn ykkar, eða ekkert, hvort sem þú vilt.
There was a problem hiding this comment.
Og rétt ártal betra, þ.e. 2022, ekki 2020-2022.
There was a problem hiding this comment.
lib/add_connection.dart
Outdated
| ), | ||
| decoration: BoxDecoration( | ||
| borderRadius: BorderRadius.circular(25.0), | ||
| color: HexColor.fromHex("#C00004"), |
There was a problem hiding this comment.
Litir af allri gerð ættu sennilega að vera teknir úr þemunni frekar en að vera harðkóðaðir.
lib/iot.dart
Outdated
| ), | ||
| ), | ||
| ]; | ||
| } |
There was a problem hiding this comment.
OK, that is an incomprehensible monster. Do people generally do stuff like this in Flutter?
pubspec.yaml
Outdated
| version: 1.3.1+15 | ||
|
|
||
| environment: | ||
| sdk: ">=2.10.0 <3.0.0" | ||
| sdk: ">=2.10.0 <3.0.0" | ||
|
|
||
| dependencies: |
There was a problem hiding this comment.
Isn't YAML usually formatted with two-space indentation? That's what VS Code does by default.
lib/add_connection.dart
Outdated
| * | ||
| * You should have received a copy of the GNU General Public License | ||
| * along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
| */ |
There was a problem hiding this comment.
It would be nice if the bottom of the header of the new Dart source files contained a brief description of the functionality contained therein.
|
I know this isn't what you'd love to be doing, @sultur, but given the rapid changes in the Embla_Flutter codebase, this pull request should be merged into master sooner rather than later to ease the pain. |
New interface, allows connecting IoT devices/accounts. Depends on IoT functionality in this Greynir PR: mideind/GreynirServer#187