Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating tests to use skipif #217

Merged
merged 5 commits into from
Aug 30, 2023
Merged

Updating tests to use skipif #217

merged 5 commits into from
Aug 30, 2023

Conversation

KariSt1
Copy link
Collaborator

@KariSt1 KariSt1 commented Aug 30, 2023

Tests now skip instead of passing if an api key or a file is required for the test but not present. Also renamed read_api_key to read_txt_api_key and added a read_json_api_key function to utility.py as not all keys are .txt files. These methods now allow for an optional folder parameter to specify if the key is not in the default resources folder. Tests for these methods were added to test_util.py.

@KariSt1 KariSt1 requested review from sveinbjornt and sultur August 30, 2023 15:23
@sveinbjornt
Copy link
Member

Good work!

@sveinbjornt sveinbjornt merged commit d9b39cf into master Aug 30, 2023
11 checks passed
@sveinbjornt sveinbjornt deleted the updating-tests branch August 30, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants