Added AboutChurchScreen #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Michaelcraun
approved these changes
Jun 22, 2024
Which include the ChurchLogoView and ChurchLogoShape, along with Primary, Secondary, and Tertiary logo color sets.
I added a color asset for our font color, and I also added an extension for Text objects to modify them to match our planned designs
I also added a color asset for the Navigation Bar and ScrollingTabView's background color
And I also updated the TextModifier so that it no longer applies padding to the top.
Due to the removal of padding in the TextModifier padding needed to be added to the ScrollingTabItems. Since the views will be different being generated by the screen method in the ScrollingTabModel, it won't work as expected so I removed the function.
And also made fine tuned the fonts and font sizes to be more dynamic.
BAChapin
added a commit
that referenced
this pull request
Jun 26, 2024
## Description <!-- Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change. --> <!-- If there is a ticket for this work item, including Github issues, please include it here as well i.e. `[<Task Name>](www.story-link.com)` --> ### Type of Change <!-- Please delete options that are not relevant. --> - [x] Feature ## Does this introduce a breaking change? <!-- If this introduces a breaking change, please add the **Breaking** tag to the PR. --> - [ ] Yes - [x] No ### Describe How This Is A Breaking Change <!-- If this PR introduces a breaking change, explain how/what it breaks. Otherwise delete this section. --> ## How Can This PR Be Tested? <!-- Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. --> <!-- Please include screenshots/video where applicable. --> **Test Configuration**: * Firmware version: * Hardware: * Is Simulator: - [ ] Yes - [ ] No ## Checklist: <!-- Please ensure the following items are taken care of as part of your PR. If they are not, your PR will NOT be approved. --> - [x] Doc strings have been added to any public APIs - [x] Appropriate tests have been added - [x] The CHANGELOG.md file has been updated with your changes (1 entry per PR) - [ ] Before merging, rebase your branch with the target branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Does this introduce a breaking change?
Describe How This Is A Breaking Change
How Can This PR Be Tested?
Test Configuration:
Checklist: