Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution for #4 #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Solution for #4 #5

wants to merge 1 commit into from

Conversation

askarby
Copy link

@askarby askarby commented Aug 21, 2020

This is a PR to support multiple source-map files (support for resolving stacktraces based on webpack chunks, eg. Angular etc.)

Solves:
#4

Please Notice: I did feature-creep a bit, while developing, so you might want to "pick'n'choose" from what you want to integrate (I added "debug"-support, "legend"-support and webstorm IDE-settings).

@sanbornhilland
Copy link

This is a very useful feature and it's awesome that @askarby put in the time to submit this PR. Is there any way we can work on moving this forward?

@sanbornhilland
Copy link

sanbornhilland commented Nov 19, 2020

@askarby It's unclear to me if this is missing a step. I'm not seeing this map to the original source files like I expect. I'm seeing a stack trace that maps to my production js bundles.

This was my fault. I was still calling it with a single map file instead of pointing at a directory. This works great when you call it correctly 😛

@mifi
Copy link
Owner

mifi commented Nov 19, 2020

Great job! Yes this PR contains a lot of unrelated changes, so someone would need to pull out the essential stuff needed to support multiple maps. I'll look into it when I have time

@Kingwl
Copy link

Kingwl commented Apr 6, 2021

Hi folks! Looking forward for this landed!

@mifi
Copy link
Owner

mifi commented Feb 27, 2022

Feel free to make a new PR with only the feature in question, and I can look into it.

@alex-kowalczyk
Copy link

@mifi Any chance to get that merged in and distribute npm package ? This would be helpful a lot!

@mifi
Copy link
Owner

mifi commented Jun 8, 2022

Does anyone have some sample source map files and minified stacktraces that reference more than one source map? Now that this code is about to become more complex I would like to write an integration test for multi-source map

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants