Skip to content

fix: Enforce NonAdminBackup spec field values #277

fix: Enforce NonAdminBackup spec field values

fix: Enforce NonAdminBackup spec field values #277

Triggered via pull request November 11, 2024 15:21
Status Failure
Total duration 2m 25s
Artifacts

ci.yml

on: pull_request
golang-check
2m 13s
golang-check
container-check
1m 8s
container-check
project-check
42s
project-check
oadp-compatibility-check
1m 12s
oadp-compatibility-check
Fit to window
Zoom out
Zoom in

Annotations

12 errors
oadp-compatibility-check
run 'make update-non-admin-manifests' in OADP repository to update Non Admin Controller (NAC) manifests
oadp-compatibility-check
Process completed with exit code 1.
golang-check: internal/common/function/function_test.go#L32
import "k8s.io/api/core/v1" imported without alias but must be with alias "corev1" according to config (importas)
golang-check: internal/common/function/function_test.go#L133
fieldalignment: struct with 48 pointer bytes could be 40 (govet)
golang-check: internal/common/function/function_test.go#L184
add-constant: string literal "*" appears, at least, 3 times, create a named constant for it (revive)
golang-check: internal/common/function/function_test.go#L195
add-constant: string literal "true" appears, at least, 3 times, create a named constant for it (revive)
golang-check: internal/common/function/function_test.go#L200
add-constant: string literal "openshift/oadp.io" appears, at least, 3 times, create a named constant for it (revive)
golang-check: internal/common/function/function_test.go#L209
add-constant: string literal "banana" appears, at least, 3 times, create a named constant for it (revive)
golang-check: internal/common/function/function_test.go#L233
add-constant: avoid magic numbers like '12', create a named constant for it (revive)
golang-check: internal/common/function/function_test.go#L234
add-constant: avoid magic numbers like '30', create a named constant for it (revive)
golang-check: internal/common/function/function_test.go#L289
add-constant: avoid magic numbers like '3', create a named constant for it (revive)
golang-check: internal/common/function/function_test.go#L290
add-constant: avoid magic numbers like '30', create a named constant for it (revive)