Skip to content

feat: Add Non Admin Restore controller #311

feat: Add Non Admin Restore controller

feat: Add Non Admin Restore controller #311

Triggered via pull request November 19, 2024 15:36
Status Failure
Total duration 2m 16s
Artifacts

ci.yml

on: pull_request
golang-check
2m 6s
golang-check
container-check
1m 13s
container-check
project-check
36s
project-check
oadp-compatibility-check
1m 22s
oadp-compatibility-check
Fit to window
Zoom out
Zoom in

Annotations

12 errors
oadp-compatibility-check
run 'make update-non-admin-manifests' in OADP repository to update Non Admin Controller (NAC) manifests
oadp-compatibility-check
Process completed with exit code 1.
golang-check: internal/common/function/function.go#L47
exported: exported function GetNonAdminRestoreLabels should have comment or be unexported (revive)
golang-check: internal/common/function/function.go#L61
exported: exported function GetNonAdminRestoreAnnotations should have comment or be unexported (revive)
golang-check: internal/common/function/function.go#L94
exported: exported function ValidateRestoreSpec should have comment or be unexported (revive)
golang-check: internal/common/function/function.go#L168
exported: exported function GetGenerateNamePrefix should have comment or be unexported (revive)
golang-check: internal/common/function/function.go#L169
add-constant: avoid magic numbers like '5', create a named constant for it (revive)
golang-check: internal/common/function/function.go#L244
exported: exported function GetVeleroRestoreByLabel should have comment or be unexported (revive)
golang-check: internal/common/function/function.go#L285
exported: exported function CheckVeleroRestoreMetadata should have comment or be unexported (revive)
golang-check: internal/controller/nonadminrestore_controller.go#L107
add-constant: avoid magic numbers like '5', create a named constant for it (revive)
golang-check: internal/controller/nonadminrestore_controller.go#L170
add-constant: string literal "Failed to update NonAdminRestore Status" appears, at least, 3 times, create a named constant for it (revive)
golang-check: internal/controller/nonadminrestore_controller.go#L238
Error return value of `r.Get` is not checked (errcheck)