Move API conditions and phases into common api file #130
Conversation
Change which moves Conditions and Phases into separate nonadmin_types.go that will be used across all other controllers within NonAdmin project. This ensures we are making them part of the API to match them closer to the design. Signed-off-by: Michal Pryc <[email protected]>
Small CRD updates to make the following PR passing: migtools/oadp-non-admin#130 Signed-off-by: Michal Pryc <[email protected]>
|
Depends on openshift/oadp-operator#1605 |
mpryc
dismissed stale reviews from kaovilai and shubham-pampattiwar
via
486b6be
Updated operations instead of backups Signed-off-by: Michal Pryc <[email protected]>
mpryc
force-pushed
the
use_common_types
branch
from
486b6be to
3969ec0
Compare
Small CRD updates to make the following PR passing: migtools/oadp-non-admin#130 Signed-off-by: Michal Pryc <[email protected]>
Small CRD updates to make the following PR passing: migtools/oadp-non-admin#130 Signed-off-by: Michal Pryc <[email protected]>
Signed-off-by: Michal Pryc <[email protected]>
Small CRD updates to make the following PR passing: migtools/oadp-non-admin#130 Signed-off-by: Michal Pryc <[email protected]>
|
/test oadp-compatibility-check |
|
@mpryc: The specified target(s) for Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kaovilai, mateusoliveira43, mpryc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Change which moves Conditions and Phases into separate nonadmin_types.go that will be used across all other controllers within NonAdmin project. This ensures we are making them part of the API to match them closer to the design.
Why the changes were made
These changes were introduced to improve the consistency of the NonAdmin project by centralizing the Conditions and Phases. Moving them to a dedicated nonadmin_types.go file provides a single source of truth within API, ensuring that any controller or component working with NonAdminBackup and NonAdminRestore objects can reference these conditions and phases in a consistent way and aligned with design documents and diagrams, ensuring that they are part of the standard data structure shared across the project.
How to test the changes made
Moving some constants and extracting common strings. Followed by running tests and linters: