Non admin status comparison against empty structure #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change implementation of the status functions to ensure that an empty status is properly compared against an empty structure, treating it as equivalent to nil Previous implementation had corner case where reconcile would lead to unnecessary updates, even both statuses were effectively "empty". Signed-off-by: Michal Pryc <[email protected]>
mateusoliveira43
approved these changes
Dec 10, 2024
shubham-pampattiwar
approved these changes
Dec 10, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mateusoliveira43, mpryc, shubham-pampattiwar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change implementation of the status functions to ensure that an empty status is properly compared against an empty structure, treating it as equivalent to nil
Previous implementation had corner case where reconcile would lead to unnecessary updates, even both statuses were effectively "empty".
Why the changes were made
To fix reconcile updates to the status where the status should not be updated.
How to test the changes made
Fix logic observed during controller manual testing.