Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TACKLE-114] create a common useFetch ReactJS Hook to be reused #110

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

carlosthe19916
Copy link
Contributor

@carlosthe19916 carlosthe19916 commented Apr 19, 2021

Resolves: #117

@codecov
Copy link

codecov bot commented Apr 19, 2021

Codecov Report

Merging #110 (5f5d09a) into main (b2095f4) will decrease coverage by 0.21%.
The diff coverage is 79.83%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #110      +/-   ##
==========================================
- Coverage   61.88%   61.67%   -0.22%     
==========================================
  Files         165      158       -7     
  Lines        3634     3452     -182     
  Branches      711      717       +6     
==========================================
- Hits         2249     2129     -120     
+ Misses       1383     1321      -62     
  Partials        2        2              
Flag Coverage Δ
e2etests 65.13% <93.39%> (+1.46%) ⬆️
unitests 25.60% <0.80%> (-6.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...components/stakeholders-form/stakeholders-form.tsx 0.00% <0.00%> (ø)
src/pages/controls/job-functions/job-functions.tsx 0.00% <0.00%> (ø)
...containers/select-tag-filter/select-tag-filter.tsx 10.52% <16.66%> (+1.70%) ⬆️
...controls/stakeholder-groups/stakeholder-groups.tsx 72.54% <90.90%> (+10.30%) ⬆️
src/pages/controls/stakeholders/stakeholders.tsx 62.96% <90.90%> (+1.42%) ⬆️
...ependencies-form/application-dependencies-form.tsx 94.02% <100.00%> (+1.87%) ⬆️
...t/components/application-form/application-form.tsx 86.17% <100.00%> (+1.28%) ⬆️
...s/controls/business-services/business-services.tsx 66.29% <100.00%> (+1.58%) ⬆️
...ts/business-service-form/business-service-form.tsx 90.00% <100.00%> (+0.86%) ⬆️
.../stakeholder-group-form/stakeholder-group-form.tsx 83.33% <100.00%> (+1.33%) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2095f4...5f5d09a. Read the comment docs.

@carlosthe19916 carlosthe19916 marked this pull request as ready for review April 20, 2021 08:56
@carlosthe19916 carlosthe19916 changed the title enhance custom hook useFetch [TACKLE-114] create a common useFetch ReactJS Hook to be reused Apr 23, 2021
# Conflicts:
#	src/shared/hooks/useFetch/useFetch.ts
# Conflicts:
#	src/pages/application-inventory/application-inventory.tsx
# Conflicts:
#	src/pages/application-inventory/application-list/application-list.tsx
#	src/pages/application-inventory/application-list/components/application-form/application-form.tsx
#	src/shared/hooks/index.ts
#	src/shared/hooks/useFetchApplications/useFetchApplications.test.tsx
#	src/shared/hooks/useFetchApplications/useFetchApplications.ts
# Conflicts:
#	src/pages/application-inventory/application-assessment/application-assessment.tsx
# Conflicts:
#	src/api/apiUtils.ts
#	src/pages/application-inventory/application-list/application-list.tsx
#	src/pages/controls/tags/tags.tsx
#	src/shared/hooks/index.ts
#	src/shared/hooks/useFetch/useFetch.test.tsx
#	src/shared/hooks/useFetch/useFetch.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TACKLE-114] create a common useFetch ReactJS Hook to be reused
1 participant