Make Nginx IPv6 enable by default but can be disable through ENV var #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # .github/workflows/pr-build-container-images.yml
Codecov Report
@@ Coverage Diff @@
## main #216 +/- ##
==========================================
+ Coverage 54.82% 56.36% +1.53%
==========================================
Files 169 169
Lines 3969 3969
Branches 778 794 +16
==========================================
+ Hits 2176 2237 +61
+ Misses 1789 1728 -61
Partials 4 4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current Nginx server enables by default both IPv4 and IPv6; however, it has been reported that certain K8s instances might not have IPv6 enabled so it is required to disable IPv6 otherwise the pod associated with the UI will throw an error:
The way of disabling IPv6 in a K8s/OCP environment will be to set an environment variable
DISABLE_IPV6whose value can betrueorfalse.If
DISABLE_IPV6=true=> the IPv6 will be disabled.If
DISABLE_IPV6=falseorDISABLE_IPV6doesn't exists => the IPv6 will be enabled.@mrizzi If this PR is merged eventually then the new ENV
DISABLE_IPV6will be also needed to be included inside the Operator source code. Ideally, the Operator should be able to detect whether or not the K8s instance has enabled/disabled IPv6 and then set the correct value toDISABLE_IPV6. Anyway, this is just a reminder for doing something on the operator side.If this PR is merged it might also be required to enhance the docs (if we have any).