Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TACKLE-316]-Tackle - Role Based Access Control #267

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

carlosthe19916
Copy link
Contributor

@github-actions
Copy link

github-actions bot commented Nov 2, 2021

Thanks for your contribution!
Every commit will generate a new build at https://github.com/carlosthe19916/tackle-ui/actions/workflows/pr-build-container-images.yml?query=branch%3Arbac and once the build finishes you should be able to use the container image ghcr.io/carlosthe19916/tackle-ui/tackle-ui:rbac
To see the full set of container images generated visit https://github.com/carlosthe19916/tackle-ui/packages

# Conflicts:
#	src/pages/application-inventory/application-list/application-list.tsx
#	src/pages/controls/business-services/business-services.tsx
#	src/pages/controls/job-functions/job-functions.tsx
#	src/pages/controls/stakeholder-groups/stakeholder-groups.tsx
#	src/pages/controls/stakeholders/stakeholders.tsx
#	src/pages/controls/tags/tags.tsx
@codecov
Copy link

codecov bot commented Nov 3, 2021

Codecov Report

Merging #267 (4ab03d4) into main (9508504) will increase coverage by 0.29%.
The diff coverage is 86.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #267      +/-   ##
==========================================
+ Coverage   63.14%   63.43%   +0.29%     
==========================================
  Files         180      183       +3     
  Lines        4322     4365      +43     
  Branches      894      908      +14     
==========================================
+ Hits         2729     2769      +40     
- Misses       1588     1591       +3     
  Partials        5        5              
Flag Coverage Δ
e2etests 69.03% <89.65%> (+0.30%) ⬆️
unitests 27.56% <11.66%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/layout/SidebarApp/SidebarApp.tsx 100.00% <ø> (ø)
...es/application-inventory/application-inventory.tsx 100.00% <ø> (ø)
...cation-inventory/manage-imports/manage-imports.tsx 0.00% <0.00%> (ø)
src/pages/controls/job-functions/job-functions.tsx 0.00% <0.00%> (ø)
...ssment-page/application-assessment-page-header.tsx 68.18% <50.00%> (-3.25%) ⬇️
...ents/custom-wizard-footer/custom-wizard-footer.tsx 95.23% <75.00%> (+0.50%) ⬆️
src/ProtectedRoute.tsx 85.71% <85.71%> (ø)
...on-inventory/application-list/application-list.tsx 61.92% <86.36%> (+2.02%) ⬆️
src/Constants.ts 100.00% <100.00%> (ø)
src/Routes.tsx 100.00% <100.00%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9508504...4ab03d4. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant