macos build issue resolved

[KMJ-007]

closes #58

[KMJ-007]

had question,

you are using nix crate, what benefits so far have you came across, and what made you choose it over syscall crate?

how did you decide?

[KMJ-007]

and current type conversion is working on macos, i haven't checked on linux and other system,

if you have any other method or safer method in your mind, let me know

[KMJ-007]

why CI didn't run?

[KMJ-007]

@mihaigalos can you review this in your free time?

[mihaigalos]

Hi @KMJ-007, seems you have some clippy errors. Since the code is still in your fork, can you please also fix them?

[KMJ-007]

Hi @KMJ-007, seems you have some clippy errors. Since the code is still in your fork, can you please also fix them?

I tried but it still says useless type conversion, but without those on macos it fails to compile cause some statfs function on macos were returning u32

what should i do?

[mihaigalos]

Sorry for replying so slow, I was very busy at work.
Ok, so we need some kind of way to tell rust to compile differently for different architectures, right?

Have a look at this, I'm open to new suggestions as well:

https://github.com/mihaigalos/url-install/blob/507a70f1d6f6e19ae6148bfffe02f374b5b6f636/src/url_install.rs#L66

[KMJ-007]

Sorry for replying so slow, I was very busy at work. Ok, so we need some kind of way to tell rust to compile differently for different architectures, right?

Have a look at this, I'm open to new suggestions as well:

https://github.com/mihaigalos/url-install/blob/507a70f1d6f6e19ae6148bfffe02f374b5b6f636/src/url_install.rs#L66

done, but i wanted more simpler solution, but at the time i didn't find that, so added target os specific code,

can you review it, in my for clippy action is green

[mihaigalos]

This is awesome. We can disregard coverage checks, I think it's something unrelated why they fail.
Thank you.

[KMJ-007]

had question,

you are using nix crate, what benefits so far have you came across, and what made you choose it over syscall crate?

how did you decide?

i am still interested in this question

[mihaigalos]

No benefits whatsoever. There is no additional sycall I need to perform and the structure is already populated with nice data instead of needing a syscall for every field.