Add Hikka Tracker Integration #1386
Conversation
|
Include "Closes #1145" in your PR description to link to the feature request issue |
|
How does the auth flow work for this site? |
I didn't mean anything special, just standard OAuth authorization. |
|
Ok I was ambiguous. How does one create a oauth client or get the reference? |
|
|
Trying to create a new client I'm getting the error "Invalid field endpoint in request body" |
|
Ok so the issue is with using the custom redirect url |
|
Blocked by hikka-io/hikka#347 |
|
I'll redo the authorisation to work after the changes then |
|
Okay, I changed the authorization. My local tests went fine |
|
I don't understand why the test fails, even though everything is fine in my fork. I didn't touch MangaScreenModel.kt at all |
|
Yeah ignore that bit. It passed lint previously but suddenly started to flag from today. |
|
Rebase please |
…asses, and add Hikka to tracker list
…nd fixed the check
…ng data in HikkaApi
Lorg0n
force-pushed
the
Add-Hikka-Tracker
branch
from
0430b85 to
2f7509e
Compare
app/src/main/java/eu/kanade/tachiyomi/data/track/hikka/dto/HKManga.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/eu/kanade/tachiyomi/data/track/hikka/dto/HKOAuth.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/eu/kanade/tachiyomi/data/track/hikka/dto/HKRead.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/eu/kanade/tachiyomi/data/track/hikka/Hikka.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/eu/kanade/tachiyomi/data/track/hikka/Hikka.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/eu/kanade/tachiyomi/data/track/hikka/HikkaApi.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/eu/kanade/tachiyomi/data/track/hikka/HikkaApi.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/eu/kanade/tachiyomi/data/track/hikka/HikkaInterceptor.kt
Outdated
Show resolved
Hide resolved
|
I just saw that Hikka merged support for start and end dates for manga. If you could add that once it's running in production it would be really cool. If I understand their code correctly, this is about starting and ending dates for the title itself, not the user's starting and ending dates of reading, so this would be used in the search like other trackers do. |
|
Unfortunately this update only applies to a request for information about a specific manga and does not give that data in a search query |
…score ref: optimize imports and reconsider domain Track usage
|
Merge in the latest change from main |
| @@ -168,6 +169,12 @@ object SettingsTrackingScreen : SearchableSettings { | |||
| login = { context.openInBrowser(BangumiApi.authUrl(), forceDefaultBrowser = true) }, | |||
| logout = { dialog = LogoutDialog(trackerManager.bangumi) }, | |||
| ), | |||
| Preference.PreferenceItem.TrackerPreference( | |||
| title = trackerManager.hikka.name, | |||
There was a problem hiding this comment.
This doesn't compile. Remove the title line and it should be good.
There was a problem hiding this comment.
And in case you're worried, it still shows Hikka in the Tracking screen.
There was a problem hiding this comment.
And in case you're worried, it still shows Hikka in the Tracking screen.
Yes, thanks, the problem appeared because I wrote back when all trackers had a title. Fixed it now
|
Somehow messed up with hiding the comment, it is not outdated. Please take a look at the requested change. |
There was a problem hiding this comment.
I think this time for real I can't find anything broken. It appeared to work once the change in b347453 was applied. Didn't do super in-depth edge case testing but cursory adding, moving, scoring, etc all seemed to work. 👍
|
Run |
|
The PR as is fine but I'll delay merging this until a small DB rework so we won't require workarounds like this Estimating a week at max |
|
I'll ask the Hikka developers about a unique number(id) for the manga, I think I'll solve the problem |
|
In case you misunderstood this is something I intent to fix Mihon side since more tracker we add in the future may not have numeric ID |
|
Okay, I got it |
Add Hikka tracker integration
Closes #1145
Add support for Hikka (https://hikka.io/), a Ukrainian online encyclopedia for manga and etc.
Changes implemented:
All changes have been tested:
Images