Fix fromHex to allow initial #

mikealmond · Jan 24, 2017 · 170ebb1 · 170ebb1
1 parent 5d8a633
commit 170ebb1
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,10 @@
 # Changelog
 
+## 0.0.2 - 2017-01-24
+
+### Fixed
+- Allow hex values to include initial #
+
 ## 0.0.1 - 2017-01-24
 
 ### Added

diff --git a/src/Color.php b/src/Color.php
@@ -102,6 +102,8 @@ public static function fromCssColor(string $color): Color
      */
     private static function hexToRgb(string $color): array
     {
+        $color = ltrim($color, '#');
+
         // Convert the shorthand hex to the full hex (09F => 0099FF)
         if (strlen($color) == 3) {
             $color = $color[0] . $color[0] . $color[1] . $color[1] . $color[2] . $color[2];

diff --git a/tests/ColorTest.php b/tests/ColorTest.php
@@ -81,6 +81,10 @@ public function testConvertsToHex()
 
         $color = Color::fromRgb(255, 0, 255);
         $this->assertEquals('FF00FF', strval($color));
+
+
+        $this->assertEquals('FF00FF', Color::fromHex('#FF00FF'));
+
     }
 
     /**
@@ -262,6 +266,7 @@ public function goodHexColors()
             ['09F'],
             ['AAABBB'],
             ['0099FF'],
+            ['#0099FF'],
         ];
     }