#57: re-factor to make it easy to deploy and support other web technologies. #64
Conversation
…eb technologies. - the displayable module knows how to display figures - the deployable module knows how to deploy figures - favor os.sep of hardcoding / in path - replaced string replace calls with jinja2 template module
|
Hello Micha, Good idea! I'll update it. -jk |
|
OK So I'm blocking the merge of this because it makes idiom changes, and it's the idioms that I'm hoping to maintain over the various changes this library will go through before it becomes useful. The first is the loss of the 'with' idiom - why has that been removed? The other is the util.display replacing fig.show(). I'm totally happy having additional display options in a util module, and I'm even happy having a discussion about the default show() method, but I'm less happy that the user has to import a separate module and make a decision about how to show the figure. Would it be possible to get the above additions into a place that doesn't involve any changes to the standard examples? Then, to demonstrate this pull requests additions, new examples could be added? |
|
Hello Mike, Thanks for your feedback. I'll follow up in the original bug #57. -jk |
…ons and committing them
|
Hello Mike, I've completed the revisions we spoke about. Please have a look at it when you get a chance. -jk |
|
I'm so sorry about the delay with this pull request. We've merged in a pull request that incorporates Vega https://github.com/trifacta/vega that completely replaces the javascript generation. We need to do a pass over the new codebase to remove the old javascript generation stuff and then we will get to working out the conflicts newly present in this request! |
|
Hello Mike, No worries. Let me know when the Vega merge is complete. -jk |
...ies.