Attempt to convert collectionFormat list items so that they validate correctly. #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unless I'm missing something, this P/R has not been merged. Does anyone have feedback that will let me know what else is needed or if what I am proposing is unacceptable in some way? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert collectionFormat lists to the specified type so that jsonschema validates correctly. For example, a parameter type such as this:
idcsv: {name: ids, description: 'list of IDs', in: query, type: array, items: {type: number, format: int32}, collectionFormat: csv, minItems: 1}
The existing code simply returns a list of strings, however, jsonschema won't validate correctly unless the items are first converted to integers.