Setup VsCode settings for remote development during mila init
#71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lebrice
force-pushed
the
vscode-mila-init
branch
from
82e9835
to
cadbf5d
Compare
lebrice
commented
Nov 9, 2023
tests/cli/test_init_command/test_setup_vscode_settings_accept_initial_settings3_.md
Outdated
Show resolved
Hide resolved
breuleux
reviewed
Nov 10, 2023
milatools/cli/vscode_utils.py
Outdated
|
|
||
|
|
||
| def vscode_installed() -> bool: | ||
| return bool(shutil.which("code")) |
There was a problem hiding this comment.
The $MILATOOLS_CODE_COMMAND can be used to customize the command to use (e.g. you could set it to code-insiders, if you're using that).
There was a problem hiding this comment.
Signed-off-by: Fabrice Normandin <[email protected]>
Signed-off-by: Fabrice Normandin <[email protected]>
Signed-off-by: Fabrice Normandin <[email protected]>
Signed-off-by: Fabrice Normandin <[email protected]>
Signed-off-by: Fabrice Normandin <[email protected]>
Signed-off-by: Fabrice Normandin <[email protected]>
Signed-off-by: Fabrice Normandin <[email protected]>
Signed-off-by: Fabrice Normandin <[email protected]>
lebrice
force-pushed
the
vscode-mila-init
branch
from
a48a9d8
to
725469b
Compare
Signed-off-by: Fabrice Normandin <[email protected]>
breuleux
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mila initnow tries to update the User settings of VsCode with a"remote.SSH.connectTimeout": 60Are there other useful entries we should add?
Anything particular to Windows/Mac/Linux?
Let us know! :)
TODOs: