new: Add bn (Bengali) language.
#161
Conversation
sudipshil9862
force-pushed
the
add-bn
branch
from
8a2b961
to
5b47e60
Compare
There was a problem hiding this comment.
Good start, just a few minor things to fix.
Another thing I forgot to add to the docs, but you'll need to add .d.ts files for the data files, as seen here: https://github.com/milesj/emojibase/tree/master/packages/data/ko
po/bn/messages.po
Outdated
|
|
||
| msgctxt "EMOJI GROUP: 7|objects" | ||
| msgid "objects" | ||
| msgstr "objects" |
There was a problem hiding this comment.
@sudipshil9862 looks like you missed a few translations in this file, or was it intentional?
There was a problem hiding this comment.
it's a mistake. changing this
po/bn/messages.po
Outdated
|
|
||
| msgctxt "EMOJI SUB-GROUP: 33|animal-mammal" | ||
| msgid "mammals" | ||
| msgstr "mammals" |
po/bn/messages.po
Outdated
|
|
||
| msgctxt "EMOJI SUB-GROUP: 71|light-video" | ||
| msgid "light, film & video" | ||
| msgstr "" |
po/bn/messages.po
Outdated
|
|
||
| msgctxt "EMOJI SUB-GROUP: 91|punctuation" | ||
| msgid "punctuation" | ||
| msgstr "punctuation" |
packages/data/bn/messages.raw.json
Outdated
| "groups": [ | ||
| { | ||
| "key": "smileys-emotion", | ||
| "message": "smileys & emotion", |
There was a problem hiding this comment.
these should be the translated messages
There was a problem hiding this comment.
how to create these .d.ts like in packages/data/bn
There was a problem hiding this comment.
does data.json mean data.json.d.ts ?
or should I rename it ?
There was a problem hiding this comment.
you can copy the compact.json.d.ts, data.json.d.ts, and messages.json.d.ts files as-is.
data.json.d.ts is typescript types for the data.json file (which is published).
|
|
@milesj anyhting else to change ? |
|
@sudipshil9862 Yeah just need to fix the failing build and then its good to go |
|
@sudipshil9862 For the shortcode test, we need to update this file: https://github.com/milesj/emojibase/blob/master/packages/regex/shortcode-native.js And include the regex for bengali. |
|
now where it's failing ? |
|
@sudipshil9862 Still on the same thing. Looks like bengali may need multiple unicode ranges? Similar to how russian works. I'm not sure what the range would be though. Just trial and error. I suggest running the tests locally |
|
in gedit, this line is showing : "্" contains a ZERO WIDTH NON-JOINER (U+200C) and a VIRAMA (U+09CD, BENGALI SIGN VIRAMA) To solve this problem we need a Unicode range |
|
@milesj please review my PR. all checks have passed |
|
@sudipshil9862 Awesome stuff. I'll publish a new version sometime in the next day. |
No description provided.