Skip to content
This repository has been archived by the owner on Feb 17, 2025. It is now read-only.

Add Makefile for build and install of org.so #19

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

schoettl
Copy link

@schoettl schoettl commented Apr 7, 2022

Hi, cool project. How about a Makefile to build and install org.so? This would simplify the installation section in the README a bit and only recompile if sources have changed...

@milisims
Copy link
Owner

milisims commented Apr 7, 2022

Thanks for the PR! I'm not sure that I want to include make install to explicitly install to the nvim parser directory.

I'm considering just grabbing the generic makefile from the tree-sitter-go repo. While that wouldn't install to a location that nvim users care about (as far as I know), it does construct a libtree-sitter-org.so.1.0 which could be linked to. It also constructs a c library/header file to include in lower level stuff, which is very cool. I could include an install for nvim specific target in the makefile. Thoughts?

I've already started to revisit the install section, because you're right it's not really very clear. I hope my comment on your issue helps with the nvim install.

@schoettl
Copy link
Author

schoettl commented Apr 7, 2022

The tree-sitter-go Makefile looks clean, too. If it's not overkill given the current state, use that. I understand that the install section is critical. You could of course leave it out.

I will try to install this tree-sitter the next days. I just set up a new ~/.config/nvim config; Now I should be able to use vim and neovim in parallel with different configs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants