Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fps_create.c #22

Closed
wants to merge 1 commit into from
Closed

Update fps_create.c #22

wants to merge 1 commit into from

Conversation

a-sevin
Copy link
Member

@a-sevin a-sevin commented Dec 20, 2023

Could we put the datadir and confdir of a FPS in /tmp ?

Could we put the datadir and confdir of a FPS in /tmp ?
@a-sevin a-sevin requested review from oguyon and DasVinch December 20, 2023 14:49
@DasVinch
Copy link
Member

Need to do an intention check with @oguyon as to the purpose of confdir and datadir. I may be 100% confused.
As I understand it they need to be persistent, at least for now:

  • confdir --> stores user-made modifs to FPS tree, and is used upon redeploy after a cleanup / reboot
  • datadir --> stores data products from the execution (mostly of one-shot FPSs, e.g. mlat, calibs). From a milk PoV, data output should stay there, and it's up to scripts of a higher layer to process / extract useful files and "upgrade" these to the conf folder.

@oguyon
Copy link
Member

oguyon commented Dec 20, 2023

confdir and datadir are indeed intended to be persistent (across computer reboots), so we don't want them to go in a tmp folder. @a-sevin what is the motivation for moving them to tmp directory ?

@a-sevin
Copy link
Member Author

a-sevin commented Dec 20, 2023

ok ok, just void the creation of a lot of directories close to our binaries :)

@oguyon
Copy link
Member

oguyon commented Dec 20, 2023

OK. The rundir could be a symlink to tmp. This would be the easiest. We wouldn't make the default.

@a-sevin
Copy link
Member Author

a-sevin commented Dec 20, 2023

No problem, I handle it on my side.

Have a happy holiday season !

@a-sevin a-sevin closed this Dec 20, 2023
@a-sevin a-sevin deleted the a-sevin/fps.dirs_in_tmp branch December 20, 2023 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants