Added setHashQuiet and replaceHashQuiet methods #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
since it's so easy to create the functions (and already on README) I don't see a reason to add it to hasher itself.. I'll keep it open for a few days/weeks to see if anyone else see the value on it, but I won't merge it for now. thanks for your contribution. |
|
Yes, in README you already have this external method. It wraps "quiet" functionality, so why don't do it in standard way ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your documentation state how to set hash without dispatching hash change event:
https://github.com/millermedeiros/Hasher#setting-hash-value-without-dispatching-changed-signal
I found this really useful, so I added wrappers for
setHashandreplaceHashmethods, which do this out of the box.Tests, readme, etc. will write if you decide to use my contribution ;)