Skip to content
This repository has been archived by the owner on Aug 16, 2023. It is now read-only.

fix compile error under mingw/windows. #684

Closed
wants to merge 1 commit into from
Closed

fix compile error under mingw/windows. #684

wants to merge 1 commit into from

Conversation

matrixji
Copy link
Contributor

@matrixji matrixji commented Feb 13, 2023 •
edited
Loading

issue: #685

Signed-off-by: Ji Bin [email protected]

@sre-ci-robot sre-ci-robot requested review from hhy3 and liliu-z February 13, 2023 06:21
@mergify mergify bot added the dco-passed DCO check passed. label Feb 13, 2023
@mergify
Copy link

mergify bot commented Feb 13, 2023

@matrixji Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

@liliu-z
Copy link
Member

liliu-z commented Feb 14, 2023

/assign @Presburger

@liliu-z liliu-z requested a review from Presburger February 14, 2023 01:50
@mergify mergify bot added the ci-passed label Feb 14, 2023
@matrixji matrixji closed this Feb 20, 2023
@mergify mergify bot removed the ci-passed label Feb 20, 2023
@liliu-z
Copy link
Member

liliu-z commented Feb 20, 2023

Hi @matrixji , sorry for taking a long time to review this PR, but we are on it now. Can I ask why we close it? Thanks.

@matrixji
Copy link
Contributor Author

Hi @matrixji , sorry for taking a long time to review this PR, but we are on it now. Can I ask why we close it? Thanks.

I think I misoperated it, today I just want have some testing on GPU with latest knowhere, and I forget I've alerady have a PR from origin:main branch, while I force PUSH it, the PR auto closed.
I'll raise it back

@matrixji
Copy link
Contributor Author

/reopen

@sre-ci-robot sre-ci-robot reopened this Feb 20, 2023
@sre-ci-robot
Copy link

@matrixji: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: matrixji
To complete the pull request process, please ask for approval from presburger after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: matrixji
To complete the pull request process, please ask for approval from presburger after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added the ci-passed label Feb 20, 2023
@mergify mergify bot added ci-passed and removed ci-passed labels Mar 7, 2023
@mergify mergify bot added ci-passed and removed ci-passed labels Mar 22, 2023
@mergify mergify bot removed the ci-passed label Mar 29, 2023
@matrixji matrixji closed this Jul 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hhy3 hhy3 Awaiting requested review from hhy3

@liliu-z liliu-z Awaiting requested review from liliu-z

@Presburger Presburger Awaiting requested review from Presburger

Assignees

@Presburger Presburger

Labels
dco-passed DCO check passed. size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@matrixji @liliu-z @sre-ci-robot @Presburger