Feature/sorted (#77)

* Fix param nil pointer * Rename Param GetParams func to String to implement Stringer interface * A scalar index: SORTED
milvus-io · Dec 7, 2020 · c846981 · c846981
1 parent ea9dcc0
commit c846981
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 5 deletions.
diff --git a/milvus/ClientProxy.go b/milvus/ClientProxy.go
@@ -104,16 +104,24 @@ func (client *Milvusclient) CreateCollection(ctx context.Context, mapping Mappin
 	var i int
 	for i = 0; i < fieldSize; i++ {
 		field := mapping.Fields[i]
+		ep := field.ExtraParams
+		if ep == nil {
+			ep = NewParams("")
+		}
 		grpcPair := make([]*pb.KeyValuePair, 1)
-		pair := pb.KeyValuePair{"params", field.ExtraParams.params,
+		pair := pb.KeyValuePair{"params", ep.params,
 			struct{}{}, nil, 0}
 		grpcPair[0] = &pair
 		grpcFields[i] = &pb.FieldParam{0, field.Name, pb.DataType(field.Type), nil,
 			grpcPair, struct{}{}, nil, 0,
 		}
 	}
 	grpcParam := make([]*pb.KeyValuePair, 1)
-	grpcParam[0] = &pb.KeyValuePair{"params", mapping.ExtraParams.params,
+	ep := mapping.ExtraParams
+	if ep == nil {
+		ep = NewParams("")
+	}
+	grpcParam[0] = &pb.KeyValuePair{"params", ep.params,
 		struct{}{}, nil, 0}
 	grpcMapping := pb.Mapping{nil, mapping.CollectionName, grpcFields, grpcParam,
 		struct{}{}, nil, 0,

diff --git a/milvus/MilvusClient.go b/milvus/MilvusClient.go
@@ -91,6 +91,9 @@ const (
 	RHNSWPQ IndexType = "RHNSW_PQ"
 	// RHNSWSQ8 RHNSW_SQ8
 	RHNSWSQ8 IndexType = "RHNSW_SQ8"
+
+	// SORTED a scalar index
+	SORTED IndexType = "SORTED"
 )
 
 // ConnectParam Parameters for connect

diff --git a/milvus/Params.go b/milvus/Params.go
@@ -23,6 +23,6 @@ func (p *Params) Set(key string, value interface{}) *Params {
 	return p
 }
 
-func (p *Params) GetParams() string {
+func (p *Params) String() string {
 	return p.params
 }
diff --git a/milvus/Params_test.go b/milvus/Params_test.go
@@ -7,13 +7,13 @@ import (
 )
 
 func TestParams_Set(t *testing.T) {
-	s := NewParams("").Set("foo", "bar").GetParams()
+	s := NewParams("").Set("foo", "bar").String()
 	s1, _ := sjson.Set("", "foo", "bar")
 	if s != s1 {
 		t.Errorf("%s should be equal to %s", s, s1)
 	}
 
-	s = NewParams("").Set("foo", "bar").Set("foo.bar", "foo.bar").GetParams()
+	s = NewParams("").Set("foo", "bar").Set("foo.bar", "foo.bar").String()
 	s1, _ = sjson.Set("", "foo", "bar")
 	s1, _ = sjson.Set(s1, "foo.bar", "foo.bar")
 	if s != s1 {